- Permissions removed (Not required - app only uses internal storage)

app/src/androidTest/java/com/appttude/h_mal/farmr/ui/BaseTest.kt

@@ -14,7 +14,6 @@ import androidx.test.espresso.assertion.ViewAssertions
 import androidx.test.espresso.matcher.RootMatchers.withDecorView
 import androidx.test.espresso.matcher.ViewMatchers
 import androidx.test.platform.app.InstrumentationRegistry
-import androidx.test.rule.GrantPermissionRule
 import com.appttude.h_mal.farmr.application.TestAppClass
 import com.appttude.h_mal.farmr.ui.utils.getShifts
 import kotlinx.coroutines.runBlocking
@@ -36,9 +35,6 @@ open class BaseTest<A : Activity>(
     private lateinit var testActivity: Activity
     private lateinit var decorView: View
 
-    @get:Rule
-    var permissionRule = GrantPermissionRule.grant(Manifest.permission.READ_EXTERNAL_STORAGE)
-
     @Before
     open fun setUp() {
         val startIntent =

app/src/main/AndroidManifest.xml

@@ -3,9 +3,6 @@
     xmlns:tools="http://schemas.android.com/tools"
     package="com.appttude.h_mal.farmr">
 
-    <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" />
-    <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />
-
     <application
         android:name=".di.ShiftApplication"
         android:allowBackup="true"

app/src/main/java/com/appttude/h_mal/farmr/ui/FragmentMain.kt

@@ -1,15 +1,10 @@
 package com.appttude.h_mal.farmr.ui
 
-import android.Manifest
-import android.app.Activity
 import android.app.AlertDialog
 import android.content.Intent
-import android.content.pm.PackageManager
 import android.os.Bundle
 import android.view.MenuItem
 import android.view.View
-import android.widget.Toast
-import androidx.core.app.ActivityCompat
 import androidx.core.content.FileProvider
 import androidx.recyclerview.widget.RecyclerView
 import androidx.recyclerview.widget.RecyclerView.AdapterDataObserver
@@ -51,7 +46,7 @@ class FragmentMain : BaseFragment<MainViewModel>(R.layout.fragment_main), BackPr
         }
         productListView = view.findViewById(R.id.list_item_view)
         productListView.adapter = mAdapter
-        emptyView  = view.findViewById(R.id.empty_view)
+        emptyView = view.findViewById(R.id.empty_view)
 
         mAdapter.registerAdapterDataObserver(object : AdapterDataObserver() {
             override fun onChanged() {
@@ -114,16 +109,12 @@ class FragmentMain : BaseFragment<MainViewModel>(R.layout.fragment_main), BackPr
             }
 
             R.id.export_data -> {
-                if (checkStoragePermissions(activity)) {
-                    AlertDialog.Builder(context)
-                        .setTitle("Export?")
-                        .setMessage("Exporting current filtered data. Continue?")
-                        .setNegativeButton(android.R.string.cancel, null)
-                        .setPositiveButton(android.R.string.ok) { _, _ -> exportData() }
-                        .create().show()
-                } else {
-                    displayToast("Storage permissions required")
-                }
+                AlertDialog.Builder(context)
+                    .setTitle("Export?")
+                    .setMessage("Exporting current filtered data. Continue?")
+                    .setNegativeButton(android.R.string.cancel, null)
+                    .setPositiveButton(android.R.string.ok) { _, _ -> exportData() }
+                    .create().show()
                 return true
             }
 
@@ -175,13 +166,6 @@ class FragmentMain : BaseFragment<MainViewModel>(R.layout.fragment_main), BackPr
     }
 
     private fun exportData() {
-        val permission =
-            ActivityCompat.checkSelfPermission(requireActivity(), Manifest.permission.WRITE_EXTERNAL_STORAGE)
-        if (permission != PackageManager.PERMISSION_GRANTED) {
-            Toast.makeText(context, "Storage permissions not granted", Toast.LENGTH_SHORT).show()
-            return
-        }
-
         val fileName = "shifthistory.xls"
         val file = File(requireContext().externalCacheDir, fileName)
 
@@ -199,24 +183,6 @@ class FragmentMain : BaseFragment<MainViewModel>(R.layout.fragment_main), BackPr
 
     }
 
-    override fun onRequestPermissionsResult(
-        requestCode: Int,
-        permissions: Array<String>,
-        grantResults: IntArray
-    ) {
-        super.onRequestPermissionsResult(requestCode, permissions, grantResults)
-        println("request code$requestCode")
-        if (requestCode == MY_PERMISSIONS_REQUEST_READ_EXTERNAL_STORAGE) {
-            if (grantResults.isNotEmpty()
-                && grantResults[0] == PackageManager.PERMISSION_GRANTED
-            ) {
-                exportDialog()
-            } else {
-                displayToast("Storage Permissions denied")
-            }
-        }
-    }
-
     private fun exportDialog() {
         AlertDialog.Builder(context)
             .setTitle("Export?")
@@ -225,22 +191,6 @@ class FragmentMain : BaseFragment<MainViewModel>(R.layout.fragment_main), BackPr
             .setPositiveButton(android.R.string.ok) { _, _ -> exportData() }.create().show()
     }
 
-    private fun checkStoragePermissions(activity: Activity?): Boolean {
-        var status = false
-        val permission = ActivityCompat.checkSelfPermission(
-            activity!!,
-            Manifest.permission.WRITE_EXTERNAL_STORAGE
-        )
-        if (permission == PackageManager.PERMISSION_GRANTED) {
-            status = true
-        }
-        return status
-    }
-
-    companion object {
-        const val MY_PERMISSIONS_REQUEST_READ_EXTERNAL_STORAGE = 1
-    }
-
     override fun onBackPressed(): Boolean {
         requireContext().createDialog(
             title = "Leave?",

app/src/main/java/com/appttude/h_mal/farmr/ui/MainActivity.kt

@@ -21,8 +21,6 @@ class MainActivity : BaseActivity() {
         toolbar = findViewById(R.id.toolbar)
         setSupportActionBar(toolbar)
 
-        verifyStoragePermissions(this)
-
         val fragmentTransaction = supportFragmentManager.beginTransaction()
         fragmentTransaction.replace(R.id.container, FragmentMain()).addToBackStack("main").commit()
     }
@@ -45,34 +43,4 @@ class MainActivity : BaseActivity() {
             }
         }
     }
-
-    // Storage Permissions
-    private val REQUEST_EXTERNAL_STORAGE = 1
-    private val PERMISSIONS_STORAGE = arrayOf(
-        Manifest.permission.READ_EXTERNAL_STORAGE,
-        Manifest.permission.WRITE_EXTERNAL_STORAGE
-    )
-
-    /**
-     * Checks if the app has permission to write to device storage
-     *
-     * If the app does not has permission then the user will be prompted to grant permissions
-     *
-     * @param activity
-     */
-    fun verifyStoragePermissions(activity: Activity?) {
-        // Check if we have write permission
-        val permission = ActivityCompat.checkSelfPermission(
-            activity!!,
-            Manifest.permission.WRITE_EXTERNAL_STORAGE
-        )
-        if (permission != PackageManager.PERMISSION_GRANTED) {
-            // We don't have permission so prompt the user
-            ActivityCompat.requestPermissions(
-                activity,
-                PERMISSIONS_STORAGE,
-                REQUEST_EXTERNAL_STORAGE
-            )
-        }
-    }
 }

app/src/main/java/com/appttude/h_mal/farmr/viewmodel/MainViewModel.kt

@@ -1,7 +1,5 @@
 package com.appttude.h_mal.farmr.viewmodel
 
-import android.Manifest.permission.WRITE_EXTERNAL_STORAGE
-import androidx.annotation.RequiresPermission
 import androidx.lifecycle.LiveData
 import androidx.lifecycle.MutableLiveData
 import androidx.lifecycle.Observer
@@ -206,7 +204,6 @@ class MainViewModel(
         refreshLiveData()
     }
 
-    @RequiresPermission(WRITE_EXTERNAL_STORAGE)
     fun createExcelSheet(file: File): File? {
         val wbSettings = WorkbookSettings().apply {
             locale = Locale("en", "EN")