From 5ff91b771eef9508e332b3cb59a6e9de74ad335a Mon Sep 17 00:00:00 2001
From: hmalik144 <h.malik144@gmail.com>
Date: Thu, 6 Feb 2020 21:50:28 +0000
Subject: [PATCH] Just some minor adjustments

---
 .idea/vcs.xml                                 |  6 +++++
 ...dRecyclerViewAdapter.kt => ListAdapter.kt} | 24 +++++++++++++++++++
 app/src/main/res/layout/feed_item.xml         |  9 ++++---
 3 files changed, 36 insertions(+), 3 deletions(-)
 create mode 100644 .idea/vcs.xml
 rename app/src/main/java/com/example/h_mal/sliidenewsreader/ui/main/{FeedRecyclerViewAdapter.kt => ListAdapter.kt} (74%)

diff --git a/.idea/vcs.xml b/.idea/vcs.xml
new file mode 100644
index 0000000..94a25f7
--- /dev/null
+++ b/.idea/vcs.xml
@@ -0,0 +1,6 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project version="4">
+  <component name="VcsDirectoryMappings">
+    <mapping directory="$PROJECT_DIR$" vcs="Git" />
+  </component>
+</project>
\ No newline at end of file
diff --git a/app/src/main/java/com/example/h_mal/sliidenewsreader/ui/main/FeedRecyclerViewAdapter.kt b/app/src/main/java/com/example/h_mal/sliidenewsreader/ui/main/ListAdapter.kt
similarity index 74%
rename from app/src/main/java/com/example/h_mal/sliidenewsreader/ui/main/FeedRecyclerViewAdapter.kt
rename to app/src/main/java/com/example/h_mal/sliidenewsreader/ui/main/ListAdapter.kt
index 2002500..6c888e9 100644
--- a/app/src/main/java/com/example/h_mal/sliidenewsreader/ui/main/FeedRecyclerViewAdapter.kt
+++ b/app/src/main/java/com/example/h_mal/sliidenewsreader/ui/main/ListAdapter.kt
@@ -1,6 +1,9 @@
 package com.example.h_mal.sliidenewsreader.ui.main
 
 import android.content.Context
+import android.content.Intent
+import android.content.Intent.FLAG_ACTIVITY_NEW_TASK
+import android.net.Uri
 import android.view.LayoutInflater
 import android.view.View
 import android.view.ViewGroup
@@ -25,14 +28,21 @@ class ListAdapter(context: Context, objects: MutableList<FeedResponse>) :
 
         val currentFeedItem = getItem(position)
 
+        //diplay the title and link to article
         view.textView.text = currentFeedItem?.title
+        view.textView.setOnClickListener {
+            openLink(position)
+        }
 
+        //initialise views
         val slider = view.seekBar
         val imageView = view.imageView
 
+        //hide views for now
         slider.visibility = View.GONE
         imageView.visibility = View.GONE
 
+        //get array of images
         val imgArray = currentFeedItem?.images
 
         imgArray?.let {
@@ -44,6 +54,7 @@ class ListAdapter(context: Context, objects: MutableList<FeedResponse>) :
             val count = it.count() -1
 
             if (count > 0){
+                //setup slides to work with image view
                 slider.visibility = View.VISIBLE
                 slider.max = count
                 slider.setOnSeekBarChangeListener(object : OnSeekBarChangeListener {
@@ -70,4 +81,17 @@ class ListAdapter(context: Context, objects: MutableList<FeedResponse>) :
             .into(imageView)
     }
 
+    //function for opening the link
+    fun openLink(position: Int){
+        val urlString = getItem(position)?.url
+        //open link to repo if the url is not null
+        if (urlString != null){
+            val openURL =  Intent(Intent.ACTION_VIEW)
+            openURL.addFlags(FLAG_ACTIVITY_NEW_TASK)
+            openURL.data = Uri.parse(urlString)
+            context.startActivity(openURL)
+        }
+
+    }
+
 }
\ No newline at end of file
diff --git a/app/src/main/res/layout/feed_item.xml b/app/src/main/res/layout/feed_item.xml
index 3014366..08797bb 100644
--- a/app/src/main/res/layout/feed_item.xml
+++ b/app/src/main/res/layout/feed_item.xml
@@ -2,20 +2,23 @@
 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:app="http://schemas.android.com/apk/res-auto"
     xmlns:tools="http://schemas.android.com/tools"
+    android:padding="16dp"
     android:orientation="vertical"
     android:layout_width="match_parent"
-    android:layout_height="match_parent">
+    android:layout_height="wrap_content">
 
     <TextView
         android:id="@+id/textView"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
-        android:text="TextView" />
+        tools:text="TextView"
+        android:layout_marginBottom="6dp"/>
 
     <ImageView
         android:id="@+id/imageView"
-        android:layout_width="wrap_content"
+        android:layout_width="match_parent"
         android:layout_height="wrap_content"
+        android:layout_marginBottom="6dp"
         tools:srcCompat="@mipmap/ic_launcher" />
 
     <SeekBar